From d7ff4aee2454fec8af75bde480d2d2f60f0d2117 Mon Sep 17 00:00:00 2001
From: Dany De Bontridder <danydb@noalyss.eu>
Date: Sat, 22 Sep 2018 17:19:35 +0200
Subject: [PATCH] Manage_Table : issue with the type select

---
 include/lib/manage_table_sql.class.php | 47 +++++++++++++-------------
 1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/include/lib/manage_table_sql.class.php b/include/lib/manage_table_sql.class.php
index 87427d300..b39e05a74 100644
--- a/include/lib/manage_table_sql.class.php
+++ b/include/lib/manage_table_sql.class.php
@@ -804,36 +804,35 @@ function check()
             }
             else
             {
-                if ( $this->get_col_type($v)=="select")
+                if ($this->get_col_type($v)=="select")
                 {
                     /**
-                     * we translate the code from the database into a hardcoded label
+                     * From database
                      */
                     $idx=$p_row[$v];
-                    if ( ! isset($this->a_select[$v][$idx])) {
-                        /*
-                        * Check if index exists
-                        */
-                        $array_to_search=$this->a_select[$v];
-                        $value=$p_row[$v];
-                        $nb_search=count($array_to_search);
-                        $found=FALSE;
-                        for ( $e=0;$e< $nb_search;$e++) {
-                            if (isset ($array_to_search[$e]['value']) && $array_to_search[$e]['value']==$value ) {
-                                $found=TRUE;
-                                echo td($array_to_search[$e]['label']);
-                            }
+                    /*
+                     * Check if index exists
+                     */
+                    $array_to_search=$this->a_select[$v];
+                    $value=$p_row[$v];
+                    $nb_search=count($array_to_search);
+                    $found=FALSE;
+                    for ($e=0; $e<$nb_search; $e++)
+                    {
+                        if (isset($array_to_search[$e]['value'])&&$array_to_search[$e]['value']==$value)
+                        {
+                            $found=TRUE;
+                            echo td($array_to_search[$e]['label']);
                         }
-
-                        if ( ! $found) {
-                            echo td("--");
-
-                        }
-                    } else {
-                        echo td($this->a_select[$v][$idx]["label"]);
                     }
-                    
-                }else {
+
+                    if (!$found)
+                    {
+                        echo td("--");
+                    }
+                }
+                else
+                {
                     echo td($p_row[$v]);
                 }
             }